Regarding: "I think the reason the custom action was scheduled for after InstallFinalize is that while removing the shortcuts is really nice on uninstall, a failure there isn't bad enough for us to prevent the user from uninstalling."
If you want a failing custom action to be ignored (and not cause a rollback) then just say so in the CA. The error result can be ignored. After InstallFinalize isn't really a technique that's required for "please ignore CA failure". The other issues you're referring to about files not getting installed and product getting registered were mentioned in my previous post - you seemed to be saying you had both old and new product versions installed, so your upgrade detection may not be working (most likely) and you're getting both products installed, or your RemoveExistingProducts may be after InstallFinalize and failing (less likely) since both will leave you with two products installed and a mishmash of files. Again, a verbose log is the standard diagnostic. Phil -----Original Message----- From: Dave Sawyer [mailto:dsaw...@box.com] Sent: Wednesday, August 07, 2013 8:48 PM To: wix-users@lists.sourceforge.net Subject: Re: [WiX-users] Installation failed, but product updated Hi Blair, Thanks for the great tip! My action is scheduled as: <Custom Action="RemoveBoxShortcuts" After="InstallFinalize">REMOVE="ALL"</Custom> I can change it to After="RemoveFolders". I'm still surprised the new files did not get installed but the product got registered. I would expect either both or neither. I think the reason the custom action was scheduled for after InstallFinalize is that while removing the shortcuts is really nice on uninstall, a failure there isn't bad enough for us to prevent the user from uninstalling. -Dave Message: 5 Date: Tue, 6 Aug 2013 17:06:48 -0700 From: Blair Murri <os...@live.com> Subject: Re: [WiX-users] Installation failed, but product updated To: General discussion for Windows Installer XML toolset. <wix-users@lists.sourceforge.net> Message-ID: <blu168-w7197c00f73b69b3fe43895cd...@phx.gbl> Content-Type: text/plain; charset="Windows-1252" When was your custom action scheduled, are you manually setting any of the ARP registry keys manually, and do you have rollback turned off? Product registration happens in the deferred phase of the RegisterProduct action, and should have rolled back if your custom action failure was after that action and before InstallFinalize. If your action is a commit action or is scheduled after InstallFinalize, the product will remain installed. Blair ---------------------------------------------------------------------------- -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
