Yes.
On Mon, Oct 17, 2011 at 8:17 PM, Hoover, Jacob
<jacob.hoo...@greenheck.com>wrote:
> While I know I could customize the BA to suite my needs, might I suggest
> a slight change to the thmutil.cpp. If a user supplies an
> IconSourceFile from within the Bundle, the primary exe file will have a
> Win32 icon resource embedded into it. If the thm.xml (or XML overridden
> by <WixVariable Id="WixStdbaThemeXml" Value="....xml"/> has windows with
> no IconFIle/IconResource element, then one would think the default
> behavior would be to Acquire the icon from the primary exe file.
>
>
>
> This could either be changed to the default behavior, or we could allow
> the IconResource implementation in thmutil.cpp to have a fallback:
>
>
>
> static HRESULT ParseApplication(
>
> __in_opt HMODULE hModule,
>
> __in_opt LPCWSTR wzRelativePath,
>
> __in IXMLDOMElement* pElement,
>
> __in THEME* pTheme
>
> )
>
> ... @ Line 1644
>
>
>
> if (S_OK == hr)
>
> {
>
> pTheme->hIcon = ::LoadIconW(hModule, bstr);
>
> ExitOnNullWithLastError(pTheme->hIcon, hr, "Failed to load
> application icon.");
>
>
>
> ReleaseNullBSTR(bstr);
>
> }
>
>
>
> to
>
>
>
> if (S_OK == hr)
>
> {
>
> pTheme->hIcon = ::LoadIconW(hModule, bstr);
>
> if (!pTheme->hIcon)
>
> {
>
> pTheme->hIcon = ::LoadIconW(::GetModuleHandle(NULL), bstr);
>
> }
>
> ExitOnNullWithLastError(pTheme->hIcon, hr, "Failed to load
> application icon.");
>
>
>
> ReleaseNullBSTR(bstr);
>
> }
>
>
>
> Would this be a valid feature request?
>
>
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2d-oct
> _______________________________________________
> WiX-users mailing list
> WiX-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-users
>
>
--
virtually, Rob Mensching - http://RobMensching.com LLC
------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
