Re: [WiX-users] Problem with quotes in CustomAction

Michael Osmond Thu, 12 May 2011 15:14:08 -0700

Hello Kevin

I have been able to do a similar thing with no problem.


I expand out the command arguments using custom actions and then pass one 
property through to the ExecCommand

This does allow you to see what is happening quite well in the log.

My approach:

        <CustomAction Id="SetVariableString1" Property="rsVariableString" 
Value="/v mode=install /v DeployReports=deploy" />
        <CustomAction Id="SetVariableString2" Property="rsVariableString" 
Value="[rsVariableString] /v folderName=&quot;[BAYREPFLDR]&quot;" />
        <CustomAction Id="SetVariableString3" Property="rsVariableString" 
Value="[rsVariableString] /v dbSource=&quot;[BAYDBSERVER]&quot;" />
        <CustomAction Id="SetVariableString4" Property="rsVariableString" 
Value="[rsVariableString] /v dbName=&quot;[BAYAPPDB]&quot;" />
        <CustomAction Id="SetVariableString5" Property="rsVariableString" 
Value="[rsVariableString] /v username=&quot;[BAYSYSUSERNAME]&quot;" />
        <CustomAction Id="SetVariableString6" Property="rsVariableString" 
Value="[rsVariableString] /v password=&quot;[BAYSYSPASSWORD]&quot;" />
        <CustomAction Id="SetVariableString7" Property="rsVariableString" 
Value="[rsVariableString] /v securitymodel=[BAYSECURITYMODEL]" />
        <CustomAction Id="SetVariableString8" Property="rsVariableString" 
Value="[rsVariableString] /v ReportsFilePath=&quot;[$AppReportsDir]\&quot;" />
        <CustomAction Id="SetVariableString9" Property="rsVariableString" 
Value="[rsVariableString] /v userGroup=&quot;[BAYREPORTSGROUP]&quot;" />
        <CustomAction Id="SetVariableString10" Property="rsVariableString" 
Value="[rsVariableString] /v adhocGroup=&quot;[BAYADHOCGROUP]&quot;" />
        <CustomAction Id="SetVariableString11" Property="rsVariableString" 
Value="[rsVariableString] /v 
reportBuilderGroup=&quot;[BAYREPORTBUILDERGROUP]&quot;" />
        <CustomAction Id="SetVariableString12" Property="rsVariableString" 
Value="[rsVariableString] /v DeployAdhoc=[DeployAdhoc]" />
        <CustomAction Id="SetVariableString13" Property="rsVariableString" 
Value="[rsVariableString] /v DeployAdhocPolicy=[BAYADHOCPOLICY]" />
        <CustomAction Id="SetVariableString14" Property="rsVariableString" 
Value="[rsVariableString] /v DeployReportsPolicy=[BAYREPORTSPOLICY] " />
        <CustomAction Id="SetVariableString15" Property="rsVariableString" 
Value="[rsVariableString] /v DeployAdhocModels=[DeployAdhocModels] " />
        <CustomAction Id="SetRptPth" Property="BAYRPTPTH" 
Value="[%SystemRoot]\system32\cmd.exe" />
        <CustomAction Id="SetRptCmd" Property="BAYRPTCMD" Value="/c &quot;echo 
Deploying reports &amp; &quot;[#RSLoader.exe]&quot; /s 
&quot;[BAYREPORTINTERNAL]&quot; /i 
&quot;[$AppReportsDir]DeployReports.rss&quot; [rsVariableString] {&amp; 
[PauseOnInstall]}&quot;"/>
        <CustomAction Id="InsRptTsk" Impersonate="yes" Execute="commit" 
ExeCommand="[BAYRPTCMD]" Property="BAYRPTPTH" />

Michael


-----Original Message-----
From: Kevin MacDonald [mailto:kevinmacdon...@gmail.com] 
Sent: Friday, 13 May 2011 7:39 AM
To: Wix Users List
Subject: [WiX-users] Problem with quotes in CustomAction

I seem to have hit a bug with quotes in CustomAction. Note the variations
below.

    <CustomAction Id='MyCustomAction' FileKey='someExe'
ExeCommand='"[MYDIR1]" "[MYDIR2]"' Return='asyncNoWait' />
    <CustomAction Id='MyCustomAction' FileKey='someExe'
ExeCommand='&quot;[MYDIR1]&quot; &quot;[MYDIR2]&quot;' Return='asyncNoWait'
/>

Either of these should work. However, when the command line parameters are
expanded out the [MYDIR2] path winds up with no quote in front of it, which
presumably causes the call to the executable to fail. I am seeing this via
the logging system of the executable. I suppose there's a chance that it's
not telling me the right thing, but that's the only logging I have to go on
because when I run the MSI with verbose logging it inextricably does not
show me what's being called or the command line parameters. You'd think that
was a pretty basic thing to log. So, after two days on this I am left blind,
and blocked from making progress. Perhaps I'll give up and fork out the
$2000 for InstallShield. Yuck.

Any tips on how to get along more nicely with Wix are most appreciated.

Thanks

Kevin
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

Re: [WiX-users] Problem with quotes in CustomAction

Reply via email to