ProductVersion is correct on both of the original MSI's (1.0 and 1.1 respectively, so they are definitely not the same!), I am using WIX only to create these (in notepad). What I have discovered is that the patch file I am generating will only patch the original installer (which I used in the comparison process). The way I am generating the patch is by comparing the two wixpdb files (of the original installer and the newest one) and then using the difference transform to generate the msp. Using this method, the patch seems to only be capable of patching whatever version was used as the base for the comparison.
This is probably due to the way I am doing it rather than a fault, but as long as I now know this is the case I can stop this from happening in the future. The things you have explained have also helped me understand how this is all working in the background so I can stop causing myself problems in the future, so thanks a lot for your help! Many thanks, Richard -----Original Message----- From: Pally Sandher [mailto:pally.sand...@iesve.com] Sent: 25 March 2010 11:59 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] MSI patching for two versions of the same MSI? That's pretty bizarre. Are you building your patches using the Windows SDK tools or WiX only? At least it's fixed for the future but it makes absolutely no sense. The only other thing I can think of which might possibly cause this is if your 1.0 & 1.1 MSI's both have the same version number set. That would make the 1.0 -> 1.1 MSP a small update where as the 1.0 -> 1.2 & 1.1 -> 1.2 are minor upgrades & as MSDN says you can't mix small updates, minor upgrades & major upgrades in the same patch. Again check the MSI's themselves, the ProductVersion property in the Property table is what you're looking for. If you want to release a bootstrapper containing both versions of the 1.2 patch to make things easier for your users I'd recommend dotNetInstaller -> http://dotnetinstaller.codeplex.com/ Palbinder Sandher Software Deployment & IT Administrator T: +44 (0) 141 945 8500 F: +44 (0) 141 945 8501 http://www.iesve.com **Design, Simulate + Innovate with the <Virtual Environment>** Integrated Environmental Solutions Limited. Registered in Scotland No. SC151456 Registered Office - Helix Building, West Of Scotland Science Park, Glasgow G20 0SP Email Disclaimer -----Original Message----- From: Richard Horsley [mailto:richard.hors...@eicltd.com] Sent: 25 March 2010 11:14 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] MSI patching for two versions of the same MSI? Productcode and Upgradecode are the same in all of the generated MSI's, its so wierd. The MSP's themselves seem to check for installed version and will only patch the version they were created for. I have worked out a way around this though. I have now created a 1.0 > 1.2 MSP and a separate 1.1 > 1.2 MSP. I have then created a test 1.3 MSP and tried all patch paths to 1.3. As long as 1.2 is installed (regardless of how it happened, either installed directly, or patched from either 1.0 or 1.1) then the 1.3 patcher runs fine. So in this instance I am going to distribute the two separate patches to get ALL clients to 1.2 and from there everything should work great. Thanks for your help! This should now work for me going forwards. Regards, Richard -----Original Message----- From: Pally Sandher [mailto:pally.sand...@iesve.com] Sent: 25 March 2010 10:53 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] MSI patching for two versions of the same MSI? I would open the MSI's themselves in InstEd! or Orca & check the ProductCode GUIDs (they'll be in the Property tables) just to make 100% sure. You may also want to check the UpgradeCodes too, shouldn't make a difference to patching though as only major upgrades should need them but it doesn't hurt to check. Autogenerated Package ID's is fine, most people need them to be different between releases. Palbinder Sandher Software Deployment & IT Administrator T: +44 (0) 141 945 8500 F: +44 (0) 141 945 8501 http://www.iesve.com **Design, Simulate + Innovate with the <Virtual Environment>** Integrated Environmental Solutions Limited. Registered in Scotland No. SC151456 Registered Office - Helix Building, West Of Scotland Science Park, Glasgow G20 0SP Email Disclaimer -----Original Message----- From: Richard Horsley [mailto:richard.hors...@eicltd.com] Sent: 25 March 2010 10:36 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] MSI patching for two versions of the same MSI? Thanks for the information! I am looking into this now. I generated both versions from the same wxs file with the same product code. However, the package ID is auto-generated, if that makes a difference? Here is the original wxs that generated both of the MSI versions: <?xml version="1.0" encoding="utf-8"?> <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> <Product Manufacturer="EIC Limited" Id="cb0970bb-b053-4980-af2d-6ecd9751babc" Language="1033" Name="EIC ED Scripts Package" Version="$(var.Version)" UpgradeCode="288d49bb-d9ab-43a0-91c3-ab0615b5500e"> <Package Id="*" Keywords="Installer" Description="EIC ED Scripts Package" Manufacturer="EIC" InstallerVersion="100" Languages="1033" Compressed="yes" SummaryCodepage="1252" /> <Property Id="ALLUSERS" Value="1" /> <SetDirectory Id="WINDOWSVOLUME" Value="[WindowsVolume]"/> <Directory Id="TARGETDIR" Name="SourceDir"> <Directory Id="WINDOWSVOLUME"> <Directory Id="directory1" DiskId="1" Name="Scripts"> <Component Id="component0" Guid="38dead98-fd8b-44ec-8de1-661d21cdee67"> <File Id="file0" Name="OpenClient.ps1" Source="edscripts\$(var.Version)\OpenClient.ps1" /> <File Id="file1" Name="OpenCreateJob.ps1" Source="edscripts\$(var.Version)\OpenCreateJob.ps1" /> <File Id="file2" Name="OpenCreateSite.ps1" Source="edscripts\$(var.Version)\OpenCreateSite.ps1" /> </Component> </Directory> </Directory> </Directory> <Feature Id="EDScriptsFeature" Title="ED Scripts Feature" Level="1"> <ComponentRef Id="component0" /> </Feature> <Media Id="1" EmbedCab="yes" Cabinet="product.cab" /> </Product> </Wix> I'm looking into your suggestion of making one patch for each msi and then merging them to make one that will work for both. I'll let you know if I make progress! Thanks, Richard -----Original Message----- From: Pally Sandher [mailto:pally.sand...@iesve.com] Sent: 25 March 2010 10:26 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] MSI patching for two versions of the same MSI? Sounds like the 1.0 & 1.1 MSI's have different Product Codes. Did you implement major upgrade functionality for 1.0 MSI -> 1.1 MSI? I had this exact same problem as I'd released v1.0 & v1.1 of a product with the same Product Code then released v1.2 with a different Product Code so I could add major upgrade support. When I recently had to release v1.3 I found problems trying to generate patches. I build patches using the msimsp/patchwiz method not the WiX only method so the following may not work or may need tweaking for WiX only patch building. You'll need 2 versions of your 1.2 MSI, one for each product code. You can simply create one & then modify a copy of it using something like InstEd or Orca (you will need to make sure they both have unique package codes too, just regenerate it for the one you're modifying). Once you've done that create a second PatchFamily for the 1.1 MSI -> 1.2 MSI & it should generate a single MSP which does both updates. However if you then need to patch to 1.3 for example you'll need to continue supporting 2 Products in this manner. This behaviour is by design. If you want to use patches (small update/minor upgrade in Windows Installer terminology), don't change the Product Code. If you want to use major upgrades you need to change the Product Code. See -> http://msdn.microsoft.com/en-us/library/aa370579.aspx Palbinder Sandher Software Deployment & IT Administrator T: +44 (0) 141 945 8500 F: +44 (0) 141 945 8501 http://www.iesve.com **Design, Simulate + Innovate with the <Virtual Environment>** Integrated Environmental Solutions Limited. Registered in Scotland No. SC151456 Registered Office - Helix Building, West Of Scotland Science Park, Glasgow G20 0SP Email Disclaimer -----Original Message----- From: Richard Horsley [mailto:richard.hors...@eicltd.com] Sent: 25 March 2010 09:32 To: wix-users@lists.sourceforge.net Subject: [WiX-users] MSI patching for two versions of the same MSI? I have a WIX patch that I need to apply to all client PC's with a particular product installed. I generated the original MSI and have the WIX script that was used to create it. The process has gone like this: MSI installer v1.0 created and distributed to 50% (ish) of client machines. MSI installer v1.1 created and distributed to other 50% of machines at a later date. MSP patcher v1.1 created to patch all original 1.0 installations to 1.1. MSP patcher v1.2 created with intention of patching all version to v1.2 The issue is this: The 1.2 MSP will install fine on clients with the 1.0 MSI, and clients who have 1.1 installed, as long as they were installed with the 1.0 MSI and then PATCHED to 1.1 using the MSP. Clients installed using the 1.1 MSI will not patch using the 1.2 patcher. IS there a way of correcting this in my patch file? Or is this behaviour by design? 1.2 Patch.wxs is as follows: <?xml version="1.0" encoding="UTF-8"?> <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> <Patch AllowRemoval="yes" Manufacturer="Company" MoreInfoURL="http://www.site.com/" DisplayName="EDScripts 1.0 to 1.2 Patch" Description="Update to all Scripts files." Classification="Rollup" TargetProductName="ED Scripts Package" > <Media Id="5000" Cabinet="RTM.cab"> <PatchBaseline Id="RTM"/> </Media> <PatchFamilyRef Id="EDScriptsPatchFamily"/> </Patch> <Fragment> <PatchFamily Id='EDScriptsPatchFamily' Version='1.2' Supersede='yes'> <ComponentRef Id="component0"/> </PatchFamily> </Fragment> </Wix> Help is much appreciated! Richard ________________________________ ######################## DISCLAIMER #################### Please consider the environment before printing this e-mail. This e-mail has been scanned for all known virus's but this is not a confirmation it is virus free. This is an e-mail from EIC Limited (Company Reg: 1086295). The contents of this e-mail are confidential. EIC Limited do not accept responsibility for the accuracy or completeness of the contents of this e-mail as it has been transmitted over a public network. If you receive this e-mail in error please accept our apology. If this is the case we would be obliged if you would contact the sender and then delete this e-mail. THIS E-MAIL AND / OR ANY REPLIES TO IT, AND ANY ATTACHMENTS MAY BE INTERCEPTED, COPIED OR MONITORED BY EIC LIMITED FOR THE PURPOSE OF MONITORING OR KEEPING RECORD OF ITS BUSINESS AND FOR THE PURPOSES SET OUT IN THE TELECOMMUNICATIONS (LAWFUL BUSINESS PRACTICES) (INTERCEPTION OF COMMUNICATIONS) REGULATIONS 2000. All statements made in this e-mail are subject to contract. The contents are not to be regarded as a contractual offer or acceptance. The sender is not authorised to bind EIC Limited. The views expressed in this e-mail are those of the sender and not necessarily those of EIC Limited. ######################## DISCLAIMER #################### ------------------------------------------------------------------------ ------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------ ------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ######################## DISCLAIMER #################### Please consider the environment before printing this e-mail. This e-mail has been scanned for all known virus's but this is not a confirmation it is virus free. This is an e-mail from EIC Limited (Company Reg: 1086295). The contents of this e-mail are confidential. EIC Limited do not accept responsibility for the accuracy or completeness of the contents of this e-mail as it has been transmitted over a public network. If you receive this e-mail in error please accept our apology. If this is the case we would be obliged if you would contact the sender and then delete this e-mail. THIS E-MAIL AND / OR ANY REPLIES TO IT, AND ANY ATTACHMENTS MAY BE INTERCEPTED, COPIED OR MONITORED BY EIC LIMITED FOR THE PURPOSE OF MONITORING OR KEEPING RECORD OF ITS BUSINESS AND FOR THE PURPOSES SET OUT IN THE TELECOMMUNICATIONS (LAWFUL BUSINESS PRACTICES) (INTERCEPTION OF COMMUNICATIONS) REGULATIONS 2000. All statements made in this e-mail are subject to contract. The contents are not to be regarded as a contractual offer or acceptance. The sender is not authorised to bind EIC Limited. The views expressed in this e-mail are those of the sender and not necessarily those of EIC Limited. ######################## DISCLAIMER #################### ------------------------------------------------------------------------ ------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------ ------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ######################## DISCLAIMER #################### Please consider the environment before printing this e-mail. This e-mail has been scanned for all known virus's but this is not a confirmation it is virus free. This is an e-mail from EIC Limited (Company Reg: 1086295). The contents of this e-mail are confidential. EIC Limited do not accept responsibility for the accuracy or completeness of the contents of this e-mail as it has been transmitted over a public network. If you receive this e-mail in error please accept our apology. If this is the case we would be obliged if you would contact the sender and then delete this e-mail. THIS E-MAIL AND / OR ANY REPLIES TO IT, AND ANY ATTACHMENTS MAY BE INTERCEPTED, COPIED OR MONITORED BY EIC LIMITED FOR THE PURPOSE OF MONITORING OR KEEPING RECORD OF ITS BUSINESS AND FOR THE PURPOSES SET OUT IN THE TELECOMMUNICATIONS (LAWFUL BUSINESS PRACTICES) (INTERCEPTION OF COMMUNICATIONS) REGULATIONS 2000. All statements made in this e-mail are subject to contract. The contents are not to be regarded as a contractual offer or acceptance. The sender is not authorised to bind EIC Limited. The views expressed in this e-mail are those of the sender and not necessarily those of EIC Limited. ######################## DISCLAIMER #################### ------------------------------------------------------------------------ ------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ######################## DISCLAIMER #################### Please consider the environment before printing this e-mail. This e-mail has been scanned for all known virus's but this is not a confirmation it is virus free. This is an e-mail from EIC Limited (Company Reg: 1086295). The contents of this e-mail are confidential. EIC Limited do not accept responsibility for the accuracy or completeness of the contents of this e-mail as it has been transmitted over a public network. If you receive this e-mail in error please accept our apology. If this is the case we would be obliged if you would contact the sender and then delete this e-mail. THIS E-MAIL AND / OR ANY REPLIES TO IT, AND ANY ATTACHMENTS MAY BE INTERCEPTED, COPIED OR MONITORED BY EIC LIMITED FOR THE PURPOSE OF MONITORING OR KEEPING RECORD OF ITS BUSINESS AND FOR THE PURPOSES SET OUT IN THE TELECOMMUNICATIONS (LAWFUL BUSINESS PRACTICES) (INTERCEPTION OF COMMUNICATIONS) REGULATIONS 2000. All statements made in this e-mail are subject to contract. The contents are not to be regarded as a contractual offer or acceptance. The sender is not authorised to bind EIC Limited. The views expressed in this e-mail are those of the sender and not necessarily those of EIC Limited. ######################## DISCLAIMER #################### ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users