Were you able to actually get that working?
I just tried that approach, but I get the exact same behavior. I think that
makes sense since after the properties are calculated, you still end up with
the same string value (DefineConstants=Name1=Value1;Name2=Value2 and only the
first pair is being recognized).
Here's a snippet from how I implemented your suggestions:
<CreateProperty Condition="$(CoreDrop) != ''"
Value="COREDROP=$(CoreDrop);$(DefineConstants)">
<Output TaskParameter="Value" PropertyName="DefineConstants" />
</CreateProperty>
<CreateProperty Value="DOCDROP=\\rpd-drops\Documents;$(DefineConstants)">
<Output TaskParameter="Value" PropertyName="DefineConstants" />
</CreateProperty>
<Message Text="MSBUILD TRACING: $(DefineConstants)" />
<MSBuild Projects="$(SolutionRoot)\Build\Core.sln"
Properties="DefineConstants=$(DefineConstants)" />
Thanks,
DoranW
-----Original Message-----
From: Alex Ivanoff [mailto:alex.ivan...@shavlik.com]
Sent: Tuesday, February 17, 2009 11:16 AM
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] WiX 3.0 + MSBuild Issues
This is what I come up with after reading the posts. Lets say you have
two properties to overwrite: BuildNumber and RevisionNumber. In wixproj
file:
<Target Name="BeforeBuild">
<CreateProperty Condition="$(BuildNumber) != ''"
Value="BuildNumber=$(BuildNumber);$(DefineConstants)">
<Output TaskParameter="Value" PropertyName="DefineConstants" />
</CreateProperty>
<CreateProperty Condition="$(RevisionNumber) != ''"
Value="RevisionNumber =$(RevisionNumber);$(DefineConstants)">
<Output TaskParameter="Value" PropertyName="DefineConstants" />
</CreateProperty>
</Target>
Then instead of overwriting DefineConstants you overwrite individual
properties.
-----Original Message-----
From: Doran Wellnitz [mailto:dor...@microsoft.com]
Sent: Tuesday, February 17, 2009 12:59
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] WiX 3.0 + MSBuild Issues
Hello,
I've reviewed both links and unfortunately I haven't been able to
resolve my issue. The second link doesn't appear to be related to my
specific issue.
The first link offers a work-around, but it looks like it was never
confirmed by anyone. After trying their method (replacing semi-colons
with the XML markup %3b, using ItemGroup for setting the parameters,
etc) I get the same behavior (only the first parameter is recognized).
Also, the example looks to be a hypothetical and doesn't use the
DefineConstants parameter.
Does anyone know of a (confirmed) method for passing multiple WiX
parameters from MSBuild? Thanks.
Thanks,
DoranW
-----Original Message-----
From: Doran Wellnitz [mailto:dor...@microsoft.com]
Sent: Monday, February 16, 2009 9:14 PM
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] WiX 3.0 + MSBuild Issues
Scratch that :)...Links got broken in email.
-----Original Message-----
From: Doran Wellnitz
Sent: Monday, February 16, 2009 9:13 PM
To: General discussion for Windows Installer XML toolset.
Subject: RE: [WiX-users] WiX 3.0 + MSBuild Issues
Thanks for the quick reply, but neither of those links appear to work...
-----Original Message-----
From: Alex Ivanoff [mailto:alex.ivan...@shavlik.com]
Sent: Monday, February 16, 2009 9:12 PM
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] WiX 3.0 + MSBuild Issues
These should get you some ideas:
http://social.msdn.microsoft.com/Forums/en-US/msbuild/thread/d0610b37-02
fa-43dc-9823-3fa867093707
http://social.msdn.microsoft.com/Forums/en-US/tfsbuild/thread/95bf6b1d-9
dae-48ba-b56d-08fa5ae26563
-----Original Message-----
From: Doran Wellnitz [mailto:dor...@microsoft.com]
Sent: Monday, February 16, 2009 22:52
To: wix-users@lists.sourceforge.net
Subject: [WiX-users] WiX 3.0 + MSBuild Issues
Hello,
I'm trying to upgrade our TFS build (MSBuild) projects to use the new
WiX 3.0 stuff. Unfortunately, I'm having a devil of a time passing all
of the preprocessor variables to the WiX project from MSBuild. My
understanding is that I should be using the DefineConstants property for
passing them in, but unfortunately it is only recognizing the first
property passed in.
Here is a snippet from the build project invoking the WiX Project:
<PropertyGroup>
<DefineConstants>COREDROP=$(CoreDrop);
DOCDROP=\\rpd-drops\Documents; RAPDROP=$(DropLocation)\$(BuildNumber)\;
LOCDROP=$(DropLocation)\$(BuildNumber)\;
DISTRIBUTEDROP=\\rpd-drops\Distribute\;</DefineConstants>
</PropertyGroup>
<MSBuild Projects="$(SolutionRoot)\Build\RAPIDCore.sln"
Properties="DefineConstants=$(DefineConstants);OutDir=$(SolutionRoot)\Bu
ild\;" >
</MSBuild>
I've tried passing them in directly in the properties, creating the
DefineConstants property by using a CreateProperty instead, etc, etc.
No matter what I try, only the first parameter is recognized (or worse
:)). I have even tried passed in each one individually, still the same
behavior...
However, if I look at the build log, it appears all parameters are being
passed and set correctly...just aren't being recognized by WiX :(:
Task "MSBuild"
Global Properties:
DefineConstants=DOCDROP=\\rpd-drops\Documents
COREDROP=\\rpd-drops\devdrop\RAPIDv1.0\1.3.0012.00
RAPDROP=\\rpd-drops\DevDrop\PkgSrc\SQLRAP\2.5.0026.00\
LOCDROP=\\rpd-drops\DevDrop\PkgSrc\SQLRAP\2.5.0026.00\
DISTRIBUTEDROP=\\rpd-drops\Distribute\
I think I could get this working if I just called it from the command
line and passed in the parameters that way, but I wanted to use the
MSBuild task integration :(.
Does anyone have any pointers or tips? I've searched all over the
internet, but I haven't been able to find that works/directly addresses
this issues. Any ideas? Thanks.
Thanks,
DoranW
------------------------------------------------------------------------
------
Open Source Business Conference (OSBC), March 24-25, 2009, San
Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the
Enterprise
-Strategies to boost innovation and cut costs with open source
participation
-Receive a $600 discount off the registration fee with the source code:
SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
------------------------------------------------------------------------
------
Open Source Business Conference (OSBC), March 24-25, 2009, San
Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the
Enterprise
-Strategies to boost innovation and cut costs with open source
participation
-Receive a $600 discount off the registration fee with the source code:
SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
------------------------------------------------------------------------
------
Open Source Business Conference (OSBC), March 24-25, 2009, San
Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the
Enterprise
-Strategies to boost innovation and cut costs with open source
participation
-Receive a $600 discount off the registration fee with the source code:
SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
------------------------------------------------------------------------
------
Open Source Business Conference (OSBC), March 24-25, 2009, San
Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the
Enterprise
-Strategies to boost innovation and cut costs with open source
participation
-Receive a $600 discount off the registration fee with the source code:
SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
