It could also be that you're setting the property to the string "1" and testing for the numeric value 1. Try testing for "1" in your condition instead.
Cheers, James -----Original Message----- From: Richard [mailto:[EMAIL PROTECTED] Sent: 06 November 2008 18:22 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Evaluation of Conditions In article <[EMAIL PROTECTED]>, <[EMAIL PROTECTED]> writes: > > I attached a VBScript CustomAction to a Control. > > > > [Control Id='Next' Type='PushButton' ...] > > [Publish Event='DoAction' Value='PerformTests']1[/Publish] > > [Publish Event='NewDialog' > > Value='VerifyReadyDlg']TestPassed=1[/Publish] > > [/Control] > > [CustomAction Id='PerformTests' BinaryKey='MyScripts' > > VBScriptCall='Perform Tests'/] > > [Binary Id='MyScripts' SourceFile='MyScripts.vbs'/] The problem is that your custom action changed a property and Windows Installer didn't recognize that the property you changed was used in a subsequent control event and was using the old value of the property in the control event condition. I've worked around this in the past by setting the property to itself in a control event after the DoAction control event. <Control Id='Next' Type='PushButton' ...> <Publish Event='DoAction' Value='PerformTests'>1</Publish> <Publish Property='TestPassed' Value='[TestPassed]'>1</Publish> <Publish Event='NewDialog' Value='VerifyReadyDlg'>TestPassed = 1</Publish> </Control> -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/> ------------------------------------------------------------------------ - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users -- This e-mail is confidential and the information contained in it may be privileged. It should not be read, copied or used by anyone other than the intended recipient. If you have received it in error, please contact the sender immediately by telephoning +44 (0)20 7623 8000 or by return email, and delete the e-mail and do not disclose its contents to any person. We believe, but do not warrant, that this e-mail and any attachments are virus free, but you must take full responsibility for virus checking. Please refer to http://www.dresdnerkleinwort.com/disc/email/ and read our e-mail disclaimer statement and monitoring policy. Dresdner Kleinwort is the trading name of the investment banking division of Dresdner Bank AG, and operates through Dresdner Bank AG, Dresdner Kleinwort Limited and their affiliated or associated companies. Dresdner Bank AG is a company incorporated in Germany with limited liability and registered in England (registered no. FC007638, place of business 30 Gresham Street, London EC2V 7PG), and is authorised by the German Federal Financial Supervisory Authority and authorised and subject to limited regulation by the Financial Services Authority ("FSA"). Details about the extent of our authorisation and regulation by the FSA are available from us on request. Dresdner Kleinwort Limited is a company incorporated in England (registered no. 551334, registered office 30 Gresham Street, London EC2V 7PG), and is authorised and regulated by the FSA. -- ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
