We think we've identified a fix for this problem. We've made sure the
strings are null terminated and also changed the strutil file so it wouldn't
be looking beyond the end of the array. After introducing this fix, we've
run our upgrades and installs 8-10 times without any failures so far (we're
still holding our breaths, though).
Two files were edited:
src/ca/serverca/scasched/scasqlstr.cpp (line 269)
Before:
// We have an ANSI string so convert it to UNICODE.
cchScript = cbScript;
hr = StrAllocStringAnsi(&pwzScriptBuffer,
reinterpret_cast<LPCSTR>(pbScript), cchScript, CP_ACP);
ExitOnFailure1(hr, "Failed to allocate WCHAR string of size
'%d'", cchScript);
After:
LPSTR pszScript = reinterpret_cast<LPSTR>(pbScript);
pszScript[cbRead] = '\0';
cchScript = cbRead;
// We have an ANSI string so convert it to UNICODE.
hr = StrAllocStringAnsi(&pwzScriptBuffer, pszScript, cchScript,
CP_ACP);
ExitOnFailure1(hr, "Failed to allocate WCHAR string of size
'%d'", cchScript);
src/dutil/strutil.cpp (Line 246)
Before:
else if (L'\0' == szSource[cchSource]) // if the source already had a
null terminator, don't count that in the character count because we track it
below
After:
else if (L'\0' == szSource[cchSource-1]) // if the source already had a
null terminator, don't count that in the character count because we track it
below
Dana
On 8/22/07, Dana Gutride <[EMAIL PROTECTED]> wrote:
>
> Hi all:
>
> We are using the latest 2.0 build of wix and are now seeing this bug
> 80-90% of the time during installs. Has anybody made any progress in
> nailing down these leaked MSI Handles in the sql custom actions?
>
> Thanks,
> Dana
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users
