I remain paranoid about doing RemoveExistingProducts after InstallFinalize. If the uninstall of the older product fails in there it rolls back and you end up with both versions of the product on the system. This is usually a disaster. It's safer to do RemoveExistingProducts in the audited sequence so that failures roll back and put the older version back on the system.
Phil Wilson -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Paulsen Sent: Wednesday, March 28, 2007 6:26 AM To: Chris Bardon Cc: wix-users@lists.sourceforge.net Subject: Re: [WiX-users] Another version of this product is already installed Chris Bardon wrote: > The way I understand things, a major upgrade will effectively do a > full uninstall of the previous version before installing the new > version, correct? Just thinking that the install would take a whole > lot longer this way, and that I'd have to make sure that certain files (e.g. > user-modified configuration files) aren't wiped out in the process. > > I'll give that a shot though-it means that I should just change the > product code with every build, but leave the upgrade code the same, > right? Right. I've found it better to delay the uninstall until after the upgrade runs, which seems to address the speed and overwriting concerns. You can do that like this: <Upgrade Id="some guid"> <UpgradeVersion OnlyDetect="no" Property="PREVIOUSVERSIONFOUND" IncludeMinimum="yes" Minimum="1.0.0" IncludeMaximum="no" Maximum="" /> </Upgrade> <InstallExecuteSequence> <RemoveExistingProducts After="InstallFinalize">PREVIOUSVERSIONFOUND</RemoveExistingProducts> </InstallExecuteSequence> -- Jeff Paulsen ------------------------------------------------------------------------ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDE V _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users