Okay I think I got it. I've quoted the parameter and it seemed to work
<CustomAction Id="InstallSwapCom.Command" Property="QtExecCmdLine" Value=""perl" "[INSTALLDIR]first.pl" "install" "[INSTALLDIR]""/> Thanks dave_c wrote: > > Hi there, > > I tried what you suggested and got the same output. > > MSI (s) (40:B8) [11:56:27:009]: PROPERTY CHANGE: Adding QtExecCmdLine > property. Its value is '"perl" "C:\Program Files\Acme\Foobar 1.0\first.pl" > install INSTALLDIR'.Action ended 11:56:27: InstallSwapCom.Command. Return > value 1. > MSI (s) (40:B8) [11:56:27:009]: Doing action: InstallSwapCom > MSI (s) (40:B8) [11:56:27:009]: Note: 1: 2205 2: 3: ActionText > Action 11:56:27: InstallSwapCom. > Action start 11:56:27: InstallSwapCom. > MSI (s) (40:40) [11:56:27:025]: Invoking remote custom action. DLL: > C:\WINDOWS\Installer\MSI867.tmp, Entrypoint: CAQuietExec > MSI (s) (40:44) [11:56:27:025]: Generating random cookie. > MSI (s) (40:44) [11:56:27:025]: Created Custom Action Server with PID > 13912 (0x3658). > MSI (s) (40:4C) [11:56:27:087]: Running as a service. > MSI (s) (40:5C) [11:56:27:087]: Hello, I'm your 32bit Impersonated custom > action server. > MSI (s) (40!FC) [11:56:27:243]: PROPERTY CHANGE: Deleting QtExecCmdLine > property. Its current value is '"perl" "C:\Program Files\Acme\Foobar > 1.0\first.pl" install INSTALLDIR'. > Action ended 11:56:27: InstallSwapCom. Return value 1. > Action ended 11:56:27: INSTALL. Return value 1. > Property(S): INSTALLDIR = C:\Program Files\Acme\Foobar 1.0\ > > and here is the code that ran it. > > <CustomAction Id="DeinstallSwapCom.Command" > Property="QtExecCmdLine" Value=""perl" > "[INSTALLDIR]first.pl" deinstall [INSTALLDIR]"/> > > Or have I done something silly again. > > > Rob Hamflett wrote: >> >> You should be able to just replace <Want to pass value of INSTALLDIR >> as a parameter here> with [INSTALLDIR]. >> >> Rob >> >> dave_c wrote: >>> Hi there, >>> >>> Is the following possible. >>> >>> I have an installer that as one of the steps allows the user to define >>> the >>> installation location. I would then like to take this parameter (using >>> msiGetProperty or whatever) and pass it into a script that I have >>> defined as >>> a customAction. >>> >>> <Feature Id='Complete' >>> Title='Server Configuration' >>> Description='Installs services required for SwapCom' >>> Display='collapse' >>> Absent='disallow' >>> ConfigurableDirectory='INSTALLDIR' >>> Level='1'> >>> <ComponentRef Id='MainExecutable' /> >>> </Feature> >>> >>> <Binary Id="wixca" src="c:\wix_v2_orig\wixca.dll"/> >>> >>> <CustomAction Id="InstallSwapCom.Command" >>> Property="QtExecCmdLine" Value=""perl" >>> "[INSTALLDIR]first.pl" install <Want to pass value of >>> INSTALLDIR >>> as a parameter here>"/> >>> >>> <CustomAction Id="InstallSwapCom" >>> BinaryKey="wixca" >>> DllEntry="CAQuietExec" >>> Execute="immediate" >>> Return="check"/> >>> >>> <CustomAction Id="DeinstallSwapCom.Command" >>> Property="QtExecCmdLine" Value=""perl" >>> "[INSTALLDIR]first.pl" deinstall INSTALLDIR"/> >>> >>> <CustomAction Id="DeinstallSwapCom" >>> BinaryKey="wixca" >>> DllEntry="CAQuietExec" >>> Execute="immediate" >>> Return="ignore"/> >>> >>> <InstallExecuteSequence> >>> <!-- If not installed, generate the install command and execute it >>> (after finializing the install) --> >>> <Custom Action="InstallSwapCom.Command" >>> After="InstallFinalize">NOT >>> Installed</Custom> >>> <Custom Action="InstallSwapCom" After="InstallSwapCom.Command">NOT >>> Installed</Custom> >>> >>> <!-- If installed, generate the uninstall command and execute it >>> (before removing any files) --> >>> <Custom Action="DeinstallSwapCom.Command" >>> Before="DeinstallSwapCom">Installed</Custom> >>> <Custom Action="DeinstallSwapCom" >>> Before="RemoveFiles">Installed</Custom> >>> </InstallExecuteSequence> >> >> >> ------------------------------------------------------------------------- >> Take Surveys. Earn Cash. Influence the Future of IT >> Join SourceForge.net's Techsay panel and you'll get the chance to share >> your >> opinions on IT & business topics through brief surveys-and earn cash >> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV >> _______________________________________________ >> WiX-users mailing list >> WiX-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wix-users >> >> > > -- View this message in context: http://www.nabble.com/Using-a-Property-as-a-parameter-in-a-customAction-tf3278071.html#a9118481 Sent from the wix-users mailing list archive at Nabble.com. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users