That is an excellent point – what if we keep the ???... syntax just for Product/@Id in that case and go with the recommendations below for everything else?

 

Thanks,

Derek

 


From: Rob Mensching [mailto:[EMAIL PROTECTED]]
Sent: Monday, July 31, 2006 8:32 AM
To: [EMAIL PROTECTED]; wix-users@lists.sourceforge.net
Subject: RE: [WiX-users] rfc: Package element changes

 

Product/@Id is a kinda' scary thing to make optional.  What if someone just accidentally forgets to add one?  Or what if someone copies an example that didn't add it?  The developer will end up with a product that is very difficult to track.

 

I appreciate the consistency proposed but I'm concerned about the potential for accidents.

 


From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Derek Cicerone
Sent: Sunday, July 30, 2006 23:16
To: wix-users@lists.sourceforge.net
Subject: [WiX-users] rfc: Package element changes

 

We’ve recently discovered that the way WiX creates merge modules is a little bit incorrect.  Every merge module has a unique guid which is used to modularize all the entries in the merge module (WiX does this properly).  However, that guid is also supposed to be used as the package code (summary information property 9) – WiX doesn’t do this properly.  Right now, WiX has an independent module guid and package code.  The package code is most likely usually generated using the ??????... syntax for Package/@Id.  I’d like to propose some changes to bring WiX schema support for merge modules closer to how the merge modules should be represented (and some related changes).

 

  1. Deprecate Module/@Guid and disallow the ????... syntax for Package/@Id under a Module element.  This removes the notion of a separate module guid and package code, while forcing a user to fill in the package code (which is also the guid used for modularization).
  2. Deprecate Package/@Compressed under a Module element.  Merge modules are always compressed, so supporting this attribute for merge modules actually has no effect, therefore it should likely be removed.

 

3. Another, non merge module related change I’d like to propose is deprecating the ???... syntax for Package/@Id and Product/@Id.  Instead, in cases where a guid should be generated, the attribute should just be omitted.  This will match how the Registry elements handle auto-generation of their identifiers when the Id attribute is missing.  This change would make the schema more consistent and succinct (which I think is always a good thing J).

 

I look forward to your feedback.

 

Thanks,

Derek

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

Reply via email to