Hello Koen! I'm BACK!!!
(Just a reminder about the context: I'm new to Wt and just playing around with it. The animateShow issue is in no way urgent for me which is why it's taken a couple of months for me to get back to it.) I have some specific questions, below: On Mon, Jan 19, 2015 at 9:10 AM, Koen Deforche <k...@emweb.be> wrote: > Hey, > > 2015-01-07 1:45 GMT+01:00 K. Frank <kfrank2...@gmail.com>: >> >> Please let me clarify to be sure I understand: >> >> 1) To use animation, I need a non-inline widget, e.g. setInline(false); >> >> But >> >> 2) Even with setInline(false);, my use case -- hiding and showing the >> same widget repeatedly -- is not expected to work correctly because >> of the bug you mention below. >> >> Is this correct? > > Yes. Just to confirm, I did add setInline(false) to my test code, and the issue with animateShow did persist. >> Again, just to confirm, does this bug mean that my test program is not >> expected to work (even with setInline(false);)? > > Yes. >> >> Is the bug fix simple? Is it something I can hand-patch in my build of >> Wt 3.3.3? > > It would be simple if it were not from the complication that the JS is > minified. I am new to JS. I think I understand this, but please let me check. "Minified" JS is legal JS, but it's been textually compressed (e.g., replace "someLongInformativeVariableName" with "a"), without modifying its semantics. Correct? In my (JS) source directory: .\wt-3.3.3\src\js I have both: WWebWidget.js and WWebWidget.min.js My understanding is that the minified file, WWebWidget.min.js, came from you guys when I downloaded the Wt source bundle, and was NOT produced when I built the Wt libraries. Correct? When I build my Wt application, I refer to the Wt include directory and the Wt libraries I built. I do not set anything that looks like JS in the include files. I do see strings in WWebWidget.obj (created when I built the Wt libraries) that look like they might have come from WWebWidget.min.js. Is the following correct? When I build the Wt libraries, the .js files are not used -- I could have deleted them right after I downloaded the source bundle. When I build the Wt libraries, the flow of information is: WWebWidget.min.js --> WWebWidget.obj --> libwt.a and when I build by Wt application, I get the relevant (minified) JS out of libwt.a at link time. > The patch is the following: > > diff --git a/src/js/WWebWidget.js b/src/js/WWebWidget.js > index 1ccdbed..8298be0 100644 > --- a/src/js/WWebWidget.js > +++ b/src/js/WWebWidget.js > @@ -261,6 +261,7 @@ WT_DECLARE_WT_MEMBER > if (hide) > el.style.display = display; > restore(el, elStyle); > + onEnd(); > }); > } > > Then you could copy WWebWidget.js to WWebWidget.min.js (not really minifying > it). Based on my above understanding, after I patch WWebWidget.js (and copy it to WWebWidget.min.js), I would need to rebuild the Wt libraries. More specifically, I would need to recompile WWebWidget.obj, and relink libwt.a, but these specific details should be taken care of by the make process. Is this all correct? As an aside, would it suffice to simply recompile WWebWidget.obj, and, when I build my application, link to WWebWidget.obj (ahead of libwt.a on the command line) to pick up the patched JS, or would that lead to some kind of multiply-defined-symbol problem, or otherwise fail? (I am using mingw-w64, a 64-bit windows version of gcc, if that matters.) > Regards, > koen Thanks very much for your help and explanations, and for Wt! K. Frank ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ witty-interest mailing list witty-interest@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/witty-interest
