What the code is silently doing is to set a maximum indent of 160
characters. This is the line:

https://gitlab.com/wireshark/wireshark/-/blob/master/epan/print_stream.c?ref_type=heads#L282

(and, lines 320 - 321)

For the purposes of writing to a file, I don't see why the indent should
have any maximum. Or, it could be a lot bigger. The MAX_INDENT in
epan/print.c, for XML output, is 2048 characters.

I have started a merge request to increase this maximum to 1024.

https://gitlab.com/wireshark/wireshark/-/merge_requests/20278

Gilbert

On Fri, May 23, 2025 at 2:11 AM Tamás Regős <reg...@gmail.com> wrote:

> Dear Community,
>
> Could anyone have a look please and confirm if the following observation
> is related to a bug?
>
> Version 4.4.6 (v4.4.6-0-gaebb20483889).
>
> One example packet is attached.
>
> I compared the two ways of exporting the packet details into a text file:
> 1. Export Packet Dissectors -> As Plain Text
> 2. Right click, Copy -> "All Visible Items"
>
> Or more precisely:
> 1. From Menu: Export Packet Dissectors -> As Plain Text with Packet Format
> "All expanded"
> 2. Right click on "NR Radio Resource Control (RRC) protocol", Expand
> Subtrees, right click again, Copy -> "All Visible Items"
>
> The results do not have the same indent at the very end.
> The result of option 1 seems to be incorrect to me.
>
> *For option 1:*
> nonCriticalExtension
>     neighCellSI-AcquisitionParameters-v1550
>     eutra-CGI-Reporting-ENDC-r15: supported (0)
>     phyLayerParameters-v1550
>     mac-Parameters-v1550
>     fdd-Add-UE-EUTRA-Capabilities-v1550
>     tdd-Add-UE-EUTRA-Capabilities-v1550
>     nonCriticalExtension
>     pdcp-ParametersNR-v1560
>     irat-ParametersNR-v1560
>     fdd-Add-UE-EUTRA-Capabilities-v1560
>     pdcp-ParametersNR-v1560
>     tdd-Add-UE-EUTRA-Capabilities-v1560
>     pdcp-ParametersNR-v1560
>     nonCriticalExtension
>     nonCriticalExtension
>     neighCellSI-AcquisitionParameters-v15a0
>     nonCriticalExtension
>     pdcp-Parameters-v1610
>     pdcp-VersionChangeWithoutHO-r16: supported (0)
>     measParameters-v1610
>     altFreqPriority-r16: supported (0)
>     mmtel-Parameters-v1610
>     ue-BasedNetwPerfMeasParameters-v1610
>     nonCriticalExtension
>     mac-Parameters-v1630
>     fdd-Add-UE-EUTRA-Capabilities-v1630
>     measParameters-v1630
>     tdd-Add-UE-EUTRA-Capabilities-v1630
>     measParameters-v1630
>     nonCriticalExtension
>     nonCriticalExtension
>     irat-ParametersNR-v1660
>     nonCriticalExtension
>     other-Parameters-v1690
>     ul-RRC-Segmentation-r16: supported (0)
>
> *For option 2:*
> nonCriticalExtension
>     neighCellSI-AcquisitionParameters-v1550
>         eutra-CGI-Reporting-ENDC-r15: supported (0)
>     phyLayerParameters-v1550
>     mac-Parameters-v1550
>     fdd-Add-UE-EUTRA-Capabilities-v1550
>     tdd-Add-UE-EUTRA-Capabilities-v1550
>     nonCriticalExtension
>         pdcp-ParametersNR-v1560
>         irat-ParametersNR-v1560
>         fdd-Add-UE-EUTRA-Capabilities-v1560
>             pdcp-ParametersNR-v1560
>         tdd-Add-UE-EUTRA-Capabilities-v1560
>             pdcp-ParametersNR-v1560
>         nonCriticalExtension
>             nonCriticalExtension
>                 neighCellSI-AcquisitionParameters-v15a0
>                 nonCriticalExtension
>                     pdcp-Parameters-v1610
>                         pdcp-VersionChangeWithoutHO-r16: supported (0)
>                     measParameters-v1610
>                         altFreqPriority-r16: supported (0)
>                     mmtel-Parameters-v1610
>                     ue-BasedNetwPerfMeasParameters-v1610
>                     nonCriticalExtension
>                         mac-Parameters-v1630
>                         fdd-Add-UE-EUTRA-Capabilities-v1630
>                             measParameters-v1630
>                         tdd-Add-UE-EUTRA-Capabilities-v1630
>                             measParameters-v1630
>                         nonCriticalExtension
>                             nonCriticalExtension
>                                 irat-ParametersNR-v1660
>                                 nonCriticalExtension
>                                     other-Parameters-v1690
>                                         ul-RRC-Segmentation-r16: supported
> (0)
>
>
> Is this a formatting bug of exporting under option 1?
>
> Thank you.
>
> Regards,
> Tamas
>
> _______________________________________________
> Wireshark-dev mailing list -- wireshark-dev@wireshark.org
> To unsubscribe send an email to wireshark-dev-le...@wireshark.org
>
_______________________________________________
Wireshark-dev mailing list -- wireshark-dev@wireshark.org
To unsubscribe send an email to wireshark-dev-le...@wireshark.org

Reply via email to