On Feb 11, 2024, at 1:53 PM, Oliver Hartkopp <socket...@hartkopp.net> wrote:
> This issue seems to be fixed in libpcap in commit e50355893cd073c0
> ("socketcan: *really* fix CAN FD support.")
>
>
> - canhdr->fd_flags &=
> ~(CANFD_FDF|CANFD_ESI|CANFD_BRS);
> + canhdr->fd_flags &=
> (CANFD_FDF|CANFD_ESI|CANFD_BRS);
Yes, *that* was the underlying reason why FD frames weren't being recognized as
such; my trained-by-C-for-about-45-years brain sometimes automatically sticks a
~ after an &=, given that A &= ~B is the "clear the B bits" C idiom, so that ~
was there where it didn't belong. e50355893cd073c0 fixed that.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
