Moreover, be sure your code compiles on the master. Changes are expected to run on top of it. Backport to older versions happen for bugfixes only. Since it looks to me this is not your case it is basically pointless to test it on top of stable versions.
On Wed, Aug 14, 2019 at 6:26 PM Graham Bloice <graham.blo...@trihedral.com> wrote: > > > On Wed, 14 Aug 2019 at 17:18, Crawford, Anthony R < > anthony.r.crawf...@charter.com> wrote: > >> Hi everyone, >> >> This week was the first time I’ve submitted code to the Wireshark >> project. My first submission was for packet-mpeg-dsmcc.c. ( >> https://code.wireshark.org/review/34258) >> >> I built and run both 2.6.10 and 3.0.3 versions of Wireshark successfully >> on my Ubuntu 16.04 VM. I would like to understand why the build bot is >> telling us it failed. >> >> Thanks, >> >> Anthony >> >> > If you click on the link in the Petri-dish message you can see the build > output. Clicking on the Valid Commit Message stdio step gives the output: > > Checking commit: c3057ce592 Updated packet-mpeg-dsmcc.c with U-N Session >> Messages >> The commit message does not follow our standards. >> Please rewrite it (there are likely whitespace issues): >> >> --- OLD/.git/COMMIT_EDITMSG >> +++ NEW/.git/COMMIT_EDITMSG >> @@ -3,5 +3,4 @@ >> Second round of changes >> >> Bug: 15994 >> - >> Change-Id: I76e65e9feabe54809184a446b160367e9f520ec1 > > > The commit message should follow our guidelines, see the Wiki page on > Submitting Patches for more details: > https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message > > Similarly looking at the compile stdio output and scanning the voluminous > output (hint check near the bottom) gives: > > home/wireshark/builders/wireshark-master-petri-dish/ubuntu-x86-64-petri-dish/build/epan/dissectors/packet-mpeg-dsmcc.c:898:27: > error: ‘dsmcc_un_sess_rsrc_mpeg_stream_types_vals’ defined but not used > [-Werror=unused-const-variable=] > static const range_string dsmcc_un_sess_rsrc_mpeg_stream_types_vals[] = { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -- > Graham Bloice > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe -- Naima is online.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
