The change has been merged. More protocols can be instrumented now to add credentials to the tap. Any request to add new protocols is welcome: contact me or file a new bug for additions.
On Tue, Jun 25, 2019 at 4:45 PM Dario Lombardo <lom...@gmail.com> wrote: > > > On Thu, Jun 20, 2019 at 12:34 PM Sake Blok | SYN-bit <sake.b...@syn-bit.nl> > wrote: > >> >> Sounds like a good compromise to me! >> >> Sake >> >> > A quick update on the change: https://code.wireshark.org/review/c/33453/ > > The code has been changed according to the feedback received. The > credentials table now lists the packet number, the protocol, the username > (if present) and the additional info (if present). The passwords are not > listed here anymore. > > A click on the packet number goes to the specified packet, in the specific > hf, where the credential (password) was taken from. > > If the username is in another packet, the click on the username brings to > the right packet. If the username is not present, a placeholder (n.a.) is > given to the user. > > Some tooltips help the user to understand what the table is providing. > > Thanks to Roland for the effort in the review and any > review/feedback/user-experience is welcome. > Dario. > -- Naima is online.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
