On 4/10/19 3:20 PM, Maynard, Chris wrote: >> -----Original Message----- >> From: Wireshark-dev [mailto:[email protected]] On >> Behalf Of Guy Harris >> Sent: Wednesday, April 10, 2019 5:35 PM >> To: Developer support list for Wireshark <[email protected]> >> Subject: Re: [Wireshark-dev] Wireshark 3.0.1 build warning on Windows >> >> Check out >> >> https://buildbot.wireshark.org/wireshark- >> 3.0/builders/Windows%20Server%202016%20x86/builds/177/steps/compile_1/l >> ogs/warnings%20%281%29 >> >> and all the builds back to 2019-04-01 - they all have the warning. > > OK, I'm not sure how you were able to navigate your way to that page, but I'm > glad you found it so I know the warning wasn't just with my environment. > > I usually start at https://buildbot.wireshark.org/wireshark-master/waterfall > and navigate my way from there. So, for example, I when looking for > warnings, I might navigate along this path for a somewhat recent build: > https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86 > https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86/builds/5118 > https://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202016%20x86/builds/5118/steps/compile_1 > > ... but here the warnings are shown as 0, and there's nothing in the stdio > log to indicate any warnings either, although I suspect this is intentional > if warnings are being redirected elsewhere (stderr or a separate warnings > file). > >> Is it intentional that we're not building with the "fail on warnings" flag >> on the >> 3.0 Windows buildbot? > > Good question. I think it is, but maybe for a very old reason that nobody > can remember?
One of the items in the major release checklist is "Set DISABLE_WERROR=ON in CMakeOptions.txt". We use the default DISABLE_WERROR setting on each of the builders, so "fail on warnings" is enabled in the master branch and disabled in each of the release branches. As I recall, the checklist step was added because enabling "fail on warnings" could cause issues in some cases, e.g. if you tried to build an older Wireshark branch using a newer, pickier compiler, or if a particular library (which might start with the letter "G") started to throw warnings about deprecated functions. I'll add "-DDISABLE_WERROR=OFF" to the CMake steps on the master-3.0, master-2.6, and master-2.4 builders. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
