On 09/16/13 14:57, Guy Harris wrote:

On Sep 16, 2013, at 7:20 AM, Anders Broman <anders.bro...@ericsson.com> wrote:

In serv_name_lookup() we call getservbyport() for ports not resolved in the 
IANA port list the function
Seems quite expensive so my question is does it add any value or can I remove 
it?

At least on UN*Xes, getservbyport() does one or more of:

        1) look in /etc/services, which is probably based on a 
(possibly-out-of-date) version of, err, umm, the IANA port list;

        2) query some network service to do a lookup - and that service is 
probably using its own database, based on a (possibly-out-of-date) version of, 
err, umm, the IANA port list.

... possibly with some modifications for local use. But I imagine the number of people who actually go through the trouble to run a customized service database to be sufficiently few that it's not worth slowing everyone else down for.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Reply via email to