On Fri, May 3, 2013 at 5:16 PM, Reinhard Speyerer <rs...@arcor.de> wrote: > Evan Huus <eapa...@gmail.com> wrote: > >> The test programs are not used in Wireshark proper, so someone with >> the proper automake-foo can disable wmem_test for older glib versions. >> Glib 2.14 is quite old at this point though, so it may just be worth >> bumping our minimum version. [...] > > Using a modified wmem_test.c which only contains a dummy main() > the Wireshark 1.10.0rc1 build now stops when trying to link > wireshark > > wireshark-fileset.o: In function `fileset_find_by_path': > /tmp/wireshark-1.10.0rc1/fileset.c:183: undefined reference to `g_strcmp0' > ui/gtk/libgtkui.a(libgtkui_a-main_menubar.o): In function `make_menu_xml': > /tmp/wireshark-1.10.0rc1/ui/gtk/main_menubar.c:3753: undefined reference to > `g_strcmp0' > /tmp/wireshark-1.10.0rc1/ui/gtk/main_menubar.c:3786: undefined reference to > `g_strcmp0' > ui/gtk/libgtkui.a(libgtkui_a-main_menubar.o): In function `make_menu_actions': > /tmp/wireshark-1.10.0rc1/ui/gtk/main_menubar.c:3841: undefined reference to > `g_strcmp0' > ui/gtk/libgtkui.a(libgtkui_a-decode_as_dlg.o): In function > `decode_add_notebook': > /tmp/wireshark-1.10.0rc1/ui/gtk/decode_as_dlg.c:2047: undefined reference to > `g_strcmp0' > ui/gtk/libgtkui.a(libgtkui_a-decode_as_dlg.o):/tmp/wireshark-1.10.0rc1/ui/gtk/decode_as_dlg.c:2049: > more undefined references to `g_strcmp0' follow > collect2: ld returned 1 exit status > > It looks like the g_strcmp0 substitute from epan/strutil.c is not > contained in the archives/objects wireshark is linked against. > A few minor adaptations still seem to be needed if we want to keep > glib 2.14 compatibility.
Just missing a WS_DLL_PUBLIC annotation on the function prototype in epan/strutil.h. I'm not at a machine I can commit from right now, but I'll fix this if nobody else gets to it before tomorrow. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
