On 05/19/2010 04:07 PM, Jakub Zawadzki wrote:
> On Wed, May 19, 2010 at 02:56:52PM +0100, Martin Mathieson wrote:
>> {&hf_q708_sanc,
>> { "Signalling Area Network Code (SANC)","q708.sanc",
>> - FT_UINT16, BASE_DEC | BASE_EXT_STRING,
>> VALS(&q708_sanc_areas_ext), 0x0,
>> + FT_UINT16, BASE_DEC | BASE_EXT_STRING,
>> VALS(&q708_sanc_areas_ext.vals), 0x0,
>> NULL, HFILL }
>> },
>
> This patch is wrong, proper way IMHO is to remove VALS() cast, i.e.
>
>> - FT_UINT16, BASE_DEC | BASE_EXT_STRING, VALS(&q708_sanc_areas_ext), 0x0,
>> + FT_UINT16, BASE_DEC | BASE_EXT_STRING, &q708_sanc_areas_ext, 0x0,
>
> Regards.
Hi,
I think you're right.
Could someone with knowledge of this feature please provide:
1. The proper conversion macro.
2. Update the comment in epan/proto.h
3. Augment the description in doc/README.developer.
Thanks,
Jaap
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
