On Jul 14, 2009, at 4:15 PM, kahou lei wrote:
> I made some changes on fibre channel support in wireshark. How can I
> submit the changes?
File a bug on bugs.wireshark.org (you'll need to open a Bugzilla
account), and attach a patch for the changes ("diff -c" or "diff -u")
- don't just attach the modified versions of source files.
See
http://www.wireshark.org/docs/wsdg_html/#ChSrcSend
> Do I need to go thru a code review before I submit the change?
No - submitting the change means "giving it to the development team
for a code review", not "adding the change to the Wireshark
repository". The code review will take place in the bug.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
