On Thu, Aug 16, 2007 at 03:10:23PM +0100, Cyrille Colin wrote: > So I basically wrote a small plugin for SMS CP -following the dev > guidelines-, and linked to GPRS-LLC and SMS-RP and it works fine.
Great! > The questions are: > - is there any interest in having this submitted back to the Wireshark > source ? Always :) Please submit it through the bug tracker (http://bugs.wireshark.org) and mark it as a patch. Include a sample capture file if possible for our verification. > - if it is the case, what is the best practice (plugin, native) and "Native" is probably easier to maintain. > recommendations for the dissector calls - restrain the calls to be > within the new protocol code, or rather use call_dissector() etc in > other dissectors, which implies a small diff on other dissectors too. It is best if you can register it in a way that it is automatically called by the other dissectors without explicit code in the other dissectors. You can use call_dissector() if you need to though. Steve _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev