A couple of weeks ago, I submitted a patch with a load of unit tests for the reassemble.c API. Anders applied the patch, but didn't want to apply the part that referred to the Makefile as he uses Windows and couldn't test under Linux.

It would be really good if this could be applied - else the unit tests are pretty useless. It's worth noting that the patch doesn't do anything until you do a "make reassemble_test".

Index: epan/Makefile.am
===================================================================
--- epan/Makefile.am	(.../svn+ssh://svn/svn-ethereal/mirror/ethereal/trunk)	(revision 12016)
+++ epan/Makefile.am	(working copy)
@@ -75,6 +75,7 @@
 	make-sminmpec.pl \
 	radius_dict.l   \
 	tvbtest.c	\
+	reassemble_test.c \
 	uat_load.l	\
 	exntest.c	\
 	doxygen.cfg.in
@@ -104,6 +105,9 @@
 libwireshark_la_LIBADD = @G_ASCII_STRTOULL_LO@ @INET_ATON_LO@ @INET_PTON_LO@ @INET_NTOP_LO@ crypt/libairpdcap.la ftypes/libftypes.la dfilter/libdfilter.la dissectors/libdissectors.la $(wslua_lib) @ADNS_LIBS@ @LIBGNUTLS_LIBS@ @LIBICONV@ @KRB5_LIBS@ @SNMP_LIBS@ @SSL_LIBS@ -lm
 libwireshark_la_DEPENDENCIES = @G_ASCII_STRTOULL_LO@ @INET_ATON_LO@ @INET_PTON_LO@ @INET_NTOP_LO@ crypt/libairpdcap.la ftypes/libftypes.la dfilter/libdfilter.la dissectors/libdissectors.la $(wslua_lib)
 
+EXTRA_PROGRAMS = reassemble_test
+reassemble_test_LDADD = $(GLIB_LIBS) libwireshark.la
+
 tvbtest: tvbtest.o tvbuff.o except.o strutil.o emem.o
 	$(LINK) $^ $(GLIB_LIBS) -lz
 

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Reply via email to