Guy Harris <[EMAIL PROTECTED]> wrote on 12/12/2006 10:55:20:

> I'd suggest moving the start_dissecting() calls into the routines that 
> process individual procedure requests and replies, and avoid generating 
> those calls if there are no items expected.
> 
I've just started having a closer look at this and I have a question.

It looks like start_dissecting does a bit more than just set up the
proto tree. It calls check_col and col_set_str.

So is it safe to not call it when there are no items or would it
be better to add a parameter to start_dissecting to stop it trying
to add the proto tree if there are no items.

Thanks for any help

Andy Ling
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Reply via email to