Here is a patch to make a few small fixes to packet-wlccp.c:

  * Null terminate one of the value strings that was missing it
  * Change a comment from LCC to LLC
  * Change the version variable from guint to guint8 to match the packet
    [it is already using tvb_get_guint8()]


Thanks,
  Steve

Index: epan/dissectors/packet-wlccp.c
===================================================================
--- epan/dissectors/packet-wlccp.c      (revision 19640)
+++ epan/dissectors/packet-wlccp.c      (working copy)
@@ -93,7 +93,8 @@
        { 4, "Local Context Manager (LCM)"  },
        { 8, "Campus Context Manager (CCM)" },
        { 0x10, "Infrastructure (ICN)"      },
-       { 0x40, "Client"                    }
+       { 0x40, "Client"                    },
+       { 0, NULL                           }
 };
 
 static const value_string cisco_pid_vals[] = {
@@ -117,7 +118,7 @@
 #define F_MIC              (1<<7)
 
 #define WLCCP_UDP_PORT 2887
-/* WLCCP also uses an LCC OUI type and an ethertype */
+/* WLCCP also uses an LLC OUI type and an ethertype */
 
 /* Forward declaration we need below */
 void proto_reg_handoff_wlccp(void);
@@ -176,8 +177,9 @@
        proto_item *ti;
        proto_tree *wlccp_tree, *wlccp_type_tree, *wlccp_flags_tree;
        gboolean relay_flag;
+       guint8 version;
        guint16 type, flags;
-       guint offset = 0, version;
+       guint offset = 0;
 
        /* Make entries in Protocol column and Info column on summary display */
        if (check_col(pinfo->cinfo, COL_PROTOCOL)) 
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Reply via email to