On 04/16/12 22:03, Morten Rønne wrote:
Add a new common module information struct for urlcache and functions to do initialization of the struct. This is intended to be a new way to more easily create Ansi and Unicode version of the functions, by doing a Ansi/Unicode preamble code that calls a common worker function that do the real work.
Is there any reason not to call Ansi function inside Unicode function?
(This is the other way then it is done in most parts of wine, the reason for this is that urlcache stores ansi strings internally. Unicode urls should probably be converted using punycode encoding (IdnToAscii?)). This patch is also introducing lots of unneeded Ansi/Unicode conversions. I'm not sure if storing all url entry related information inside a structure makes anything easier/more readable. Especially when you need to make sure that a field is initialized before accessing it.
