On 8 June 2010 00:56, Alexander Scott-Johns <[email protected]> wrote: > Thomas, > > On 7 June 2010 20:04, Thomas Heckel <[email protected]> wrote: >> Hi Alexander, >> >> I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d >> "Proberly skip if functions are not available" made test errors on NT4 >> and Win95 test instead of a skip while it works on newer windows >> platforms as expected. > > I have no idea. > > I can't see the real difference between tests/printf.c and (say) > tests/locale.c: both use win_skip, but printf.c fails and locale.c > works. Maybe it's the _CRT_NON_CONFORMING_SWPRINTFS define?
All, Could someone test the attached patch on Win95 or NT4, please? I want to see if it makes the tests fail. Best regards, Alex Scott-Johns PS: make crosstest doesn't work for me: ~/wine-git/dlls/msvcrt/tests$ make crosstest i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -I../../../include/msvcrt -I./.. -DWINE_STRICT_PROTOTYPES -DWINE_CROSSTEST -I/home/user/include -g -O0 -o locale.cross.o locale.c ../../../tools/winegcc/winegcc -b i586-mingw32msvc -B../../../tools/winebuild --sysroot=../../.. --lib-suffix=.cross.a cpp.cross.o data.cross.o dir.cross.o environ.cross.o file.cross.o headers.cross.o heap.cross.o locale.cross.o misc.cross.o printf.cross.o scanf.cross.o signal.cross.o string.cross.o time.cross.o testlist.cross.o -o msvcrt_crosstest.exe -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lwinecrt0 collect2: ld returned 1 exit status winegcc: i586-mingw32msvc-gcc failed make: *** [msvcrt_crosstest.exe] Error 2 ~/wine-git/dlls/msvcrt/tests$
From c21095873ab0845887c0911b07d2d42bcf51009f Mon Sep 17 00:00:00 2001 From: Alexander Scott-Johns <[email protected]> Date: Tue, 8 Jun 2010 12:48:57 +0100 Subject: [PATCH] msvcrt/tests: Temporarily add _CRT_NON_CONFORMING_SWPRINTFS to locale.c to see what happens. --- dlls/msvcrt/tests/locale.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index cf51c4c..9e2031b 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define _CRT_NON_CONFORMING_SWPRINTFS + #include <locale.h> #include "wine/test.h" -- 1.6.0.4
