On 6/3/2010 23:35, Andrew Eikum wrote:

This fixes a bug with Internet Explorer 6's Favorites menu.

This function used to be named IUnknown_EnumObjects, so my guess is
that the original implementor thought it'd be wise to verify the type
of the object before executing IShellFolder's methods on it.  Since
it's now called IShellFolder_EnumObjects and explicitly takes an
LPSHELLFOLDER parameter, I see no reason to do the typecheck.
And where is a test for that?

---
  dlls/shlwapi/ordinal.c         |   19 +------------------
  dlls/shlwapi/tests/Makefile.in |    2 +-
  dlls/shlwapi/tests/ordinal.c   |   32 ++++++++++++++++++++++++++++++++
  3 files changed, 34 insertions(+), 19 deletions(-)



Reply via email to