XRender colors have 4 16-bit components and in that way are generic. We use r8g8b8 all the time for colors (palette.c if I remember correctly always scales the text color to r8g8b8). Without this patch wrong colors are used in a japanese game someone mentioned in the xrender thread. The app in question created 16-bit dibsections after I unlocked more depths and the color of text was wrong.
Roderick On Mon, Aug 3, 2009 at 8:47 AM, Henri Verbeet<[email protected]> wrote: > 2009/8/2 Roderick Colenbrander <[email protected]>: >> Hi, >> >> The text color of a physdev is in 24-bit r8g8b8 independent of the >> depth, so make sure the picture format passed to get_xrender_color is >> also in this format. This prepares for dibsections with support in >> depths other than the screen depth. >> > Shouldn't the format of the pixel be compatible with the picture > you're using it on? > > >
