On Feb 10, 2008 1:11 PM, Luke Benstead <[EMAIL PROTECTED]> wrote:
> This unimplemented function causes the .NET framework 3.0 installer to fail
> (and also Visual C++ express 8.0) with this patch the installer continues
> further before crashing. This is my first ever patch on Wine (and working
> with GIT) so I'm sure I've done something wrong, if so I apologize in
> advance :)
>
> diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
> index 643f9cc..9fb6906 100644
> --- a/dlls/msi/msi.c
> +++ b/dlls/msi/msi.c
> @@ -992,6 +992,7 @@ end:
> return state;
> }
>
> +
> INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd)
> {
> INSTALLUILEVEL old = gUILevel;
Random whitespace change -> bad.
> @@ -1008,6 +1009,18 @@ INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL
> dwUILevel, HWND *phWnd)
> return old;
> }
>
> +/***********************************************************************
> + * MsiSetExternalUIRecord [EMAIL PROTECTED]
> + */
> +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER puiHandler,
> + DWORD
> dwMessageFilter, LPVOID pvContext,
> +
> PINSTALLUI_RECORD_HANDLER ppuiPrevHandler )
> +{
> + FIXME("%p %08x %p %p",
> + puiHandler, dwMessageFilter, pvContext,
> ppuiPrevHandler);
> + return ERROR_CALL_NOT_IMPLEMENTED;
> +}
> +
> INSTALLUI_HANDLERA WINAPI MsiSetExternalUIA(INSTALLUI_HANDLERA puiHandler,
> DWORD dwMessageFilter, LPVOID pvContext)
> {
Used tabs -> bad.
> @@ -2452,3 +2465,5 @@ UINT WINAPI MsiAdvertiseScriptA( LPCSTR szScriptFile,
> DWORD dwFlags,
> debugstr_a( szScriptFile ), dwFlags, phRegData, fRemoveItems );
> return ERROR_CALL_NOT_IMPLEMENTED;
> }
> +
> +
More random whitespace changes.
> @@ -573,6 +576,7 @@ UINT WINAPI MsiAdvertiseScriptW(LPCWSTR, DWORD, PHKEY,
> BOOL);
> UINT WINAPI MsiCloseHandle(MSIHANDLE);
> UINT WINAPI MsiCloseAllHandles(void);
> INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL, HWND*);
> +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER, DWORD, LPVOID,
> PINSTALLUI_RECORD_HANDLER);
Inconsistent whitespace. The rest of the file does not have spaces
after parentheses.
--
James Hawkins
