On Fri, 2006-06-16 at 15:25 +0200, Alexandre Julliard wrote:
> Paul Vriens <[EMAIL PROTECTED]> writes:
> 
> > +    SetLastError(0xdeadbeef);
> > +    bAppThemed = pIsAppThemed();
> > +    todo_wine
> > +    {
> > +        ok( bAppThemed == FALSE, "Expected FALSE as this test executable 
> > is not (yet) themed.\n");
> > +        ok( GetLastError() == S_OK,
> > +            "Expected S_OK, got 0x%08lx\n",
> > +            GetLastError());
> > +    }
> 
> This won't work right if theming is disabled, since IsAppThemed
> returns FALSE in that case. Also note that GetLastError doesn't return
> an HRESULT, so ERROR_SUCCESS is a better name than S_OK.
> 
Well, tests (XP-enabled and W2K3-disabled) both return FALSE as our app
is not themed (I guess).

I'll do some rediffs and tests and start again. First patch will change
S_OK into ERROR_SUCCESS.

Cheers,

Paul.



Reply via email to