On 16/03/2019 14:35, Bartosz Dziewoński wrote:
On 2019-03-16 14:48, Merlijn van Deen (valhallasw) wrote:
1. According to the policy, self-+2'ing is grounds for revocation of
Gerrit
privileges. For a Toolforge tool, self +2-ing is common and expected:
the
repository is hosted on Gerrit to allow for CI and to make contributions
from others easier, not necessarily for the code review features.
The policy calls out this case as acceptable:
"For extensions (and other projects) not deployed to the Wikimedia
cluster, the code review policy is up to the maintainer or author of
the extension. Some non-Wikimedia extensions follow Wikimedia's policy
of prohibiting self-merges, but there is no requirement of that. If
you are the only person writing the extension and have nobody to
review your change, or if the extension is abandoned, it is acceptable
to self-merge your changes."
The problem is now it's a lot more difficult to start scaling beyond
that. Perhaps we simply need an exception for this, too, in these cases?
-I
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l