On Sun, Jul 8, 2018 at 12:49 PM, Adam Wight <[email protected]> wrote:
> Strange--the "UseContributionTracking" variable is still a thing, although > it's reported as unused by the script. See > https://github.com/wikimedia/operations-mediawiki-config/ > blob/master/wmf-config/CommonSettings.php#L2098 > > I get correct results when querying manually: > https://codesearch.wmflabs.org/search/api/v1/search? > repos=*&rng=:20&i=nope&files=&q=(\%27|%22|wg)UseContributionTracking > > The script looks for wg* variables assigned or read in wmf-config that yield no search results in any other Wikimedia git repo. Normally, when a wg variable is assigned in wmf-config it is to set it to a certain value, to be consumed by MediaWiki core (or an extension). In the case of wgUseContributionTracking, it is not a MediaWiki setting. Rather, it is an internal setting created in wmf-config/CommonSettings, solely for to be used in wmf-config/InitialiseSettings.php. The concept of temporary variables internal to wmf-config is quite common. However, the script won't (and shouldn't) find those normally because those variables are conventionally prefixed "wmg", instead of "wg". But, the ContributionTracking setting uses the "wg" prefix. Hence, the false positive because this is a "wg" setting referenced exclusively within wmf-config. -- Timo _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
