"Catrope" changed the status of MediaWiki.r112918 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112918#c31941
Old Status: new
New Status: ok
Commit summary for MediaWiki.r112918:
fix for bug34781 - display old title text if the namespace has been changed
Catrope's comment:
This is OK, but I would prefer to always to this if the two titles are
different, not just if their namespaces are different. With this, if a page is
moved within the same namespace, the "originally created as" text isn't shown.
You could accomplish this with something like:
<pre>
$oldTitle = Title::makeTitle( $row->rc_namespace, $row->rc_title );
if ( !$title->equals( $oldTitle ) ) {
...
}
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
