"Awjrichards" posted a comment on MediaWiki.r112752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112752#c31860
Commit summary for MediaWiki.r112752: Refactored checks to see if we should be displaying the MobileFrontend view and removed dependency on looking for /only/ x-device headers so we handle previously unhandled cases where a user is using useformat=mobile; As part of refactor added methods to check if a user is coming from a mobile device (denoted by presense of x-device headers) or if a user is coming from a 'faux' mobile device (when using something like useformat=mobile); Added query string handling for mobile URL construction; Added corresponding tests; Added some additional cleanup to the tearDown routine in tests to unset x-device headers and refresh the value of ExtMobileFrontend:: to its default state. Awjrichards's comment: This is part of an ongoing effort to make the MobileFrontend extension usable to others besides the Wikimedia Foundation. This is a pretty early step, but it begins to reduce the exclusive reliance on using X-Device headers to determine whether or not to display the mobile view as well as lays some groundwork for continuing in that direction. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
