"MaxSem" posted a comment on MediaWiki.r112988.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112988#c31805

Commit summary for MediaWiki.r112988:

make file an argument, --title is script specific

--file did not make that many sense, it is easier to just pass the filename
as an argument

Call to parent constructor was misplaced, that made the script specific
options pretends they were generic maintenance parameters.

MaxSem's comment:

Use $this->error() instead of manual fwrite()

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to