"Krinkle" posted a comment on MediaWiki.r111734.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111734#c31793

Commit summary for MediaWiki.r111734:

Do not set the grammarForms from test, a mistake in r111727
in [lang].js directly use the language code instead of getting from mw.config.
convertGrammar for hy and updates for bs, he, hsb

Krinkle's comment:

We should probably add mw.language.data to the list of context-sensitive 
objects that should be reset in the teardown of each unit test (just like 
mw.messages and mw.config).

Not setting it from the test is also fine, but if you want to do a test like 
that. It's possible as long as you reset it afterwards (or implement it in 
QUnit.newMwEnvironment)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to