"Wikinaut" changed the status of MediaWiki.r111350 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31159
Old Status: fixme New Status: new Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item <description> Wikinaut's comment: "Be careful here - PHP may not necessarily be compiled with mb string support as it is a non-default extension. Before relying on mb functions, perhaps ensure they exist with function_exists(). " No, it is not. As already mentioned in the comment, GlobalFunctions.php automatically wraps the mb_ function if it does not exists. The indentation is perfect. The switch is a very fine layout here. Reset to NEW _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
