"Bawolff" posted a comment on MediaWiki.r111263. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30788
Commit summary for MediaWiki.r111263: initial import of new extension EtherpadLite Bawolff's comment: Also two other things: Might be nicer to use <code>wfAppendQuery()</code> instead of constructing the url with string concatenation, and for the boolean parameters (<code>!empty( $args['show-controls'] ) )...</code>) it should definitly validate that they are either true or false. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
