"Danwe" posted a comment on MediaWiki.r111220. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111220#c30756
Commit summary for MediaWiki.r111220: Missing files from r111215 Danwe's comment: How about re-designing the 'Parameter' class in Validator 0.5, having inherited classes for each data type instead of handling them all internally. And then, instead of using extra criterion/manipulation for them, the basic logic for each type could be handled internally. Already had that thought a few times when working with Validator. Also, I think quite often we do something expensive in some ParameterCriterion, just to do the same again in ParameterManipulation, without caching it the first time. Mostly they come together anyway, so perhaps they could simply be put together in one class. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
