"Gregchiasson" posted a comment on MediaWiki.r110086.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110086#c30308

Commit summary for MediaWiki.r110086:

AFT5 - SQL statements to rebuild the rollup tables using only bucket 1, and a 
fix to prevent loading errors if a record with no timestamp comes up (which 
should be impossible anyway, but has happened on dev, and should be handled 
either way, instead of breaking the page).

Gregchiasson's comment:

There was a requirement from Fabrice to make the Special page only show 
feedback from bucket 1, which meant that the "X feedback posts on this article" 
line needed to be updated to only count from bucket 1 (this comes from 
aft_article_filter_count), as well as the counts in the filter dropdown. Since 
that doesn't exist on production at the moment it would have to be populated 
anyway, and this change just populates it properly according to the new 
requirements.

The main rollup tables probably don't need updating, I just threw that in there 
to get rid of what are now unused rows (from buckets 2 and 3) for 
completenesses sake - they already group by field_id, which is a function of 
bucket ID, so the table can actually be left alone and it shouldn't cause 
problems.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to