"Kaldari" changed the status of MediaWiki.r109726 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109726#c30135

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109726:

[ApiSandbox] front-end makeover
* Use bolded table headings
* jQuery UI buttons
* Row highlighting and more padding/spacing, less clutter
* moving  main buttons out of the table to the top right above the form
* keeping submit button below the form
* duplicate submit button above the form
* automatically scroll down to the response after a request is processed

Kaldari's comment:

 +    descTxt = smartEscape( this.info.description );
 ...
 +    descTxt = descTxt.replace( /^([^\r\n\.]*)/, '$1' ) + ' ';

The second line doesn't do anything but add a space (as the functionality of 
the regex has been removed). You could replace the above lines with just:

 descTxt = smartEscape( this.info.description ) + ' ';

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to