"Reedy" posted a comment on MediaWiki.r107980.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107980#c30100
Commit summary for MediaWiki.r107980:
* Added supported for container sharding via existing FileRepo-style hash
paths. For sharded containers, all paths used to store files must be hashed
appropriately (or the path will be rejected as invalid).
* Tweaked FileBackend::isValidContainerName() length check to give some head
room for shard and segment container names.
* Updated FSFileBackend to use new resolveStoragePathReal() function for file
paths.
* Removed useless cache invalidation in FileBackend::concatenateInternal().
Reedy's comment:
Fail.
is now
<pre>
return new FileBackendShardListIterator( $this,
$fullCont, $this->getContainerSuffixes(
$shortCont ), $params );
</pre>
but not enough parameters are passed for the FileBackendShardListIterator
constructor
<pre>
public function __construct(
FileBackend $backend, $container, $dir, array $suffixes, array
$params
) {
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
