"^demon" changed the status of MediaWiki.r109990 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109990
Old status: new > New status: ok Commit summary for MediaWiki.r109990: [Xml/Html] new method Html::namespaceSelector * Using params and option arrays instead of 4 random parameters like Xml::namespaceSelector did * Right now it's passing $selectAttribs['name'] to Xml::label, this is done because that's what Xml::namespaceSelector did. However it's wrong since labels associate over ID not NAME. Will fix in the next commit, making sure unit tests stay functional first. This bug has been in Xml::namespaceSelector for a long time but usually unnoticed as people kept either defaults. Although it was easy to get wrong as the NAME was configurable but the ID was hardcoded in Xml::namespaceSelector. * Deprecated Xml::namespaceSelector and made it cal Html::namespaceSelector * Follows-up r109974, r109698 * XmlTest.php still runs successfully _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
