"Aaron Schulz" posted a comment on MediaWiki.r109847. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109847#c29944
Commit summary for MediaWiki.r109847: Fix for r109720: replace the last two regexes with plain string functions. The regular expression used for stripping the last path component from the output was inefficient, because PCRE does not optimise "$" anchors correctly. It scans the entire string forwards, instead of scanning backwards starting from the anchor. Passes tests. Aaron Schulz's comment: Au contraire, it clearly should be implemented as a MediaWiki extension wrapped around a custom C zend extension. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
