"Aaron Schulz" changed the status of MediaWiki.r109823 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109823#c29940
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109823: FileOp: allow creation of an empty file When creating a file but ommitting the 'content' key, it would throw a notice. Using getParams let us forget about the 'content' key and hence create files with no content. Aaron Schulz's comment: Why would you omit the 'content' key? Maybe it would be better to add requiredParams() (similar to FileOp::allowedParams()) and give a Status error when they are not set (in precheck()). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
