"Reedy" posted a comment on MediaWiki.r108367.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108367#c29539
Commit summary for MediaWiki.r108367:
Fix the regression pointed out by Robin in r105855.
Reedy's comment:
<pre>
phpunit:
[exec] PHPUnit 3.5.15 by Sebastian Bergmann.
[exec]
[exec] ............................................................. 61
/ 2987 ( 2%)
[exec] ............................................................. 122
/ 2987 ( 4%)
[exec] ............................................................. 183
/ 2987 ( 6%)
[exec] ............................................................. 244
/ 2987 ( 8%)
[exec] ............................................................. 305
/ 2987 ( 10%)
[exec] ............................................................. 366
/ 2987 ( 12%)
[exec] ............................................................. 427
/ 2987 ( 14%)
[exec] ............................................................. 488
/ 2987 ( 16%)
[exec] ............................................................. 549
/ 2987 ( 18%)
[exec] ............................................................. 610
/ 2987 ( 20%)
[exec] ............................................................. 671
/ 2987 ( 22%)
[exec] ............................................................. 732
/ 2987 ( 24%)
[exec] ............................................................. 793
/ 2987 ( 26%)
[exec] ............................................................. 854
/ 2987 ( 28%)
[exec] ............................................................. 915
/ 2987 ( 30%)
[exec] ............................................................. 976
/ 2987 ( 32%)
[exec] ............................................................. 1037
/ 2987 ( 34%)
[exec] ............................................................. 1098
/ 2987 ( 36%)
[exec] ............................................................. 1159
/ 2987 ( 38%)
[exec] ............................................................. 1220
/ 2987 ( 40%)
[exec] ............................................................. 1281
/ 2987 ( 42%)
[exec] ............................................................. 1342
/ 2987 ( 44%)
[exec] ............................................................. 1403
/ 2987 ( 46%)
[exec] ............................................................. 1464
/ 2987 ( 49%)
[exec] ............................................................. 1525
/ 2987 ( 51%)
[exec] ............................................................. 1586
/ 2987 ( 53%)
[exec] ............................................................. 1647
/ 2987 ( 55%)
[exec] ............................................................. 1708
/ 2987 ( 57%)
[exec] ............................................................. 1769
/ 2987 ( 59%)
[exec] ............................................................. 1830
/ 2987 ( 61%)
[exec] ............................................................. 1891
/ 2987 ( 63%)
[exec] ............................................................. 1952
/ 2987 ( 65%)
[exec] ..FF.......F................................................. 2013
/ 2987 ( 67%)
[exec] ............................................................. 2074
/ 2987 ( 69%)
[exec] ............................................................. 2135
/ 2987 ( 71%)
[exec] ............................................................. 2196
/ 2987 ( 73%)
[exec] ............................................................. 2257
/ 2987 ( 75%)
[exec] ............................................................. 2318
/ 2987 ( 77%)
[exec] ...................................................I......... 2379
/ 2987 ( 79%)
[exec] ............................................................. 2440
/ 2987 ( 81%)
[exec] ............................................................. 2501
/ 2987 ( 83%)
[exec] ............................................................. 2562
/ 2987 ( 85%)
[exec] ............................................................. 2623
/ 2987 ( 87%)
[exec] ............................................................. 2684
/ 2987 ( 89%)
[exec] ............................................................. 2745
/ 2987 ( 91%)
[exec] ............................................................. 2806
/ 2987 ( 93%)
[exec] ............................................................. 2867
/ 2987 ( 95%)
[exec] ........II........
[exec]
[exec] Time: 02:28, Memory: 182.00Mb
[exec]
[exec] There were 3 failures:
[exec]
[exec] 1) ParserTests::testParserTest with data set #614 ('Edit comment
with section link (non-local, eg in history list)', '/* External links */
removed bogus entries', '<span class="autocomment"><a
href="/wiki/Main_Page#External_links" title="Main Page">→</a>External links:
</span> removed bogus entries', 'comment title=[[Main Page]]', '')
[exec] Edit comment with section link (non-local, eg in history list)
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<span class="autocomment"><a href="/wiki/Main_Page#External_links"
title="Main Page">→</a>External links: </span> removed bogus entries
[exec] +<a href="/wiki/Main_Page#External_links" title="Main
Page">→</a><span dir="auto"><span class="autocomment">External links: </span>
removed bogus entries</span>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 2) ParserTests::testParserTest with data set #615 ('Edit comment
with section link (local, eg in diff view)', '/* External links */ removed
bogus entries', '<span class="autocomment"><a
href="#External_links">→</a>External links: </span> removed bogus entries',
'comment local title=[[Main Page]]', '')
[exec] Edit comment with section link (local, eg in diff view)
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<span class="autocomment"><a href="#External_links">→</a>External
links: </span> removed bogus entries
[exec] +<a href="#External_links">→</a><span dir="auto"><span
class="autocomment">External links: </span> removed bogus entries</span>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 3) ParserTests::testParserTest with data set #623 ('Space
normalisation on autocomment (bug 22784)', '/* __hello__world__ */', '<span
class="autocomment"><a href="/wiki/Main_Page#hello_world" title="Main
Page">→</a>__hello__world__</span>', 'comment
[exec] title=[[Main Page]]', '')
[exec] Space normalisation on autocomment (bug 22784)
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<span class="autocomment"><a href="/wiki/Main_Page#hello_world"
title="Main Page">→</a>__hello__world__</span>
[exec] +<a href="/wiki/Main_Page#hello_world" title="Main
Page">→</a><span dir="auto"><span
class="autocomment">__hello__world__</span></span>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] --
[exec]
[exec]
[exec] There were 3 incomplete tests:
[exec]
[exec] 1) ApiTest::testApiListPages
[exec] Somebody needs to finish loving me
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/api/ApiTest.php:214
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 2) CodeDiffHighlighterTest::testParseChunksFromWindowsDiff
[exec] This test did not perform any assertions
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 3) CodeDiffHighlighterTest::testParseChunksFromUnixDiff
[exec] This test did not perform any assertions
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] �[37;41m�[2KFAILURES!
[exec] �[0m�[37;41m�[2KTests: 2885, Assertions: 35412, Failures: 3,
Incomplete: 3.
[exec] �[0m�[2K
BUILD FAILED
/var/lib/jenkins/jobs/MediaWiki-phpunit/build.xml:95: exec returned: 1
Total time: 2 minutes 30 seconds
Build step 'Invoke Ant' marked build as failure
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.4 (default)
[xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found
with the pattern 'logs/junit.xml' relative to
'/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace' for the testing framework
'PHPUnit-3.4 (default)'.
[xUnit] [INFO] - Setting the build status to FAILURE
[xUnit] [INFO] - Stopping recording.
IRC notifier plugin: Sending notification to: #mediawiki
Finished: FAILURE
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
