"Aaron Schulz" posted a comment on MediaWiki.r108274. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29481
Commit summary for MediaWiki.r108274: * Added WikiPage to RequestContext and related so that it can be shared to avoid creating a new object each time and thus avoiding database queries to load the state of the object * Added Article::getPage() as accessor to the WikiPage object so that it can be set in the context from MediaWiki::initializeArticle() * Use it WikiPage::main() to call doViewUpdates() I'm doing to this now so that I can revert r105790 and use the WikiPage object before the 1.19 release Aaron Schulz's comment: <pre>$page = WikiPage::factory( $this->getTitle() );</pre> It always created a page from the title. Now it has to worry about the wikipage being set. I'd recommend letting getWikiPage() return null and then having the doViewUpdates() code check if a wiki page is set before calling that function. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
