"Aaron Schulz" posted a comment on MediaWiki.r107776.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107776#c29234
Commit summary for MediaWiki.r107776:
* Display all errors in showForm() instead of only the first one
* First do some checks and then delete the target page instead of the opposite
so we don't delete a page for no purpose if a problem arises
* Changed some empty() checks to count()
* Use Title::quickUserCan() to see whether to show the checkbox to delete the
page or not instead of User::isAllowed()
Aaron Schulz's comment:
<pre>198 if ( count( $err ) ) {</pre>
Should this be "if ( count == 1 )" ?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
