"Hashar" posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29180
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Hashar's comment:
The function documentations need an update.
What is the points of query2 ? fixUrlQueryArgs() adds yet another layer of
stuff that is prone to break and make the framework harder for little benefits.
Just use one $query argument that should either be a string or an array. That
would make things wayyy easier to maintain in the long term.
FakeTitle methods should be updated to reflect Title changes.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
