"Hashar" posted a comment on MediaWiki.r108363. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108363#c29176
Commit summary for MediaWiki.r108363: * bug 33571: fix yottabits/s in Language::formatBitrate Problem was caused by inexact floating-point comparisons with values returned from log10(); worked around by simply duplicating the very similar code in the function immediately below, which does the same thing with 1024 instead of 1000 unit sizes, uses only simple division, and passes the test cases. Hashar's comment: What should '999999' gives in kbps ? * 999kbps * 999,999kbps * 1,000kbps I find the later acceptable. Thanks brion for the fix! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
